php-tuf / composer-stager

Stages Composer commands so they can be safely run on a codebase in production.
MIT License
16 stars 8 forks source link

Fix process error output-capturing broken by upstream regression #368

Closed TravisCarden closed 5 months ago

TravisCarden commented 5 months ago

Processes recently stopped capturing error output and tests started failing due to an upstream regression in Symfony Process reported in https://github.com/symfony/symfony/pull/57317. We can't pin to the last working version, because we can't constrain our users; and the internals upstream make it impossible to selectively extend and override. So this PR temporarily works around it by just forking \Symfony\Component\Process\Process and the few internal classes it depends on. Happily, it requires very little code modification, and it has no impact on the public API.