php-twinfield / twinfield

PHP 7.3+ Library for using the Twinfield API.
https://accounting.twinfield.com/webservices/documentation/#/
Other
33 stars 78 forks source link

Fixing issue where default was converted to 0 or 1 in the xml #185

Closed rojtjo closed 3 years ago

rojtjo commented 3 years ago

Address default attribute requires a string value of true or false. Currently booleans are converted to 0 or 1 when building the xml which makes the request fail.

rojtjo commented 3 years ago

This might actually cause backward compatibility issues for people who insert false as a string since "false" ? "true" : "false" will always return "true".

willemstuursma commented 3 years ago

Cheers.