Move the Empty Check on $cassetteName Up

php-vcr / phpunit-testlistener-vcr

Integrates PHPUnit with PHP-VCR.

MIT License

61 stars 50 forks source link

Closed chrisguitarguy closed 6 years ago

chrisguitarguy commented 6 years ago

So we don't do substr on a null and throw a TypeError

Closes #29

I added a test case to reproduce this issue first if you'd like to see it fail.

andrej-griniuk commented 6 years ago

Also faced this issue. Anything else needs to be done here to get it merged @adri @renatomefi ?

renatomefi commented 6 years ago

Thank you @chrisguitarguy!

@andrej-griniuk you can now update to v3.2.1