search

php / doc-base

Tools for the PHP documentation
Other
347 stars 91 forks source link

Handle extensions state #145

Closed jimwins closed 3 months ago

jimwins commented 3 months ago

Related to php/doc-en#3643.

cmb69 commented 3 months ago

Great! Thank you @jimwins!

Note though that checking out to en is customary, and looking for doc-en breaks the usual expectations.

I tried the script without the doc-en changes, and it works fine.

cmb69 commented 3 months ago

@Girgias, since you've worked on that script, you may want to have a look.

jimwins commented 3 months ago

Okay, rebased without the doc-en change and fixed up my local setup.

Girgias commented 3 months ago

I'm confused why the CI is complaining about the extensions.xml file not being up to date

cmb69 commented 3 months ago

I think the script would need to be run without the --check flag.

jimwins commented 3 months ago

Because now that the script handles State, doc-en is out of date. Thus php/doc-en#3645.

cmb69 commented 3 months ago

And doc-en is green!