search

php / doc-base

Tools for the PHP documentation
Other
347 stars 91 forks source link

Remove backported revcheck compatibility #176

Closed alfsb closed 2 weeks ago

alfsb commented 2 weeks ago

This PR removes some of backported revcheck behaviors, that seems incorrect or makes count debugging difficult. They new behaviors are:

  1. Tracks chmonly/ as translatable;
  2. Tracks extensions.xml as translatable;
  3. Counts and lists ok and old exclusively.

The first change will include 4 files as translatable, the second will mark one file as translatable and possibly a few as NotInEn. The last does not change file tracking or listing, but it causes a lot of changes on translator listing.

What it does is counting Ok and Old cases in separated counters, and push all other situations on a "Other" counter. So after this, file count and file listing of outdated cases will match, and RevtagProblem will not be counted as Outdated.

Note that RevtagProblem cannot be listed alongside with Outdated anyways, because it's not possible to generate diff links in this case. This changes will make count debug vastly easier, as it removes all instances of possibly not counted cases in a lot of corner cases.

Reviews and commentary welcome. I plan to push this PR next week if there are no objections.

This PR supersedes https://github.com/php/doc-base/issues/175.

alfsb commented 2 weeks ago

Merged. Now, local revcheck will slight differ from hosted revcheck, as it is tracking chmonly and some reserved.xml files, and also counting changes on translator summary.

I do plan make two, possibly three changes (robust log parsing, strict rev-skip positioning, visual tweaks), beyond the already opened PR for sequential skip-revcheck.

Let me know if systems people want to wait to all changes before updating, or want to mentioned or have issues opened in each instance.