search

php / doc-base

Tools for the PHP documentation
Other
343 stars 85 forks source link

Provides easy access to diffs from GitHub, local and git.php.net #23

Closed alfsb closed 3 years ago

alfsb commented 3 years ago

Change the modified file section to provide:

An alternative is to create a "tig.php.net": a mirror from GitHub of canonical repositories managed there, with gitweb installed, to provide a reliable, not external, source of text and html diffs for editors and translators.

kamil-tekiela commented 3 years ago

Why did you not name the variables properly? What's the point in adding comments if you could name the variables? Is there some rule that prevents us from using more than 2 characters for variable names?

alfsb commented 3 years ago

What's the point in adding comments if you could name the variables?

The comments are about the variables contents, not the variables names. It's only a hint for future -- yet unlikely -- debuggers of this sad situation.

cmb69 commented 3 years ago

What is the point of having diffs with git.php.net, since that is no longer used?

nilgun commented 3 years ago

An option for old files,

github.com result: https://github.com/php/doc-en/compare/96c9d88bad9a7d7d44bfb7f26c226df7ee9ddf26..f85d380904ca6cfcc5d71d5efe44d6a4a673e2b1#diff-7d8771e20183d6a2a27f3abd85c79eea92a17991e58554fc05a6892fd0279557

git.php.net result: https://git.php.net/?p=doc/en.git;a=blobdiff;f=reference/image/functions/imageline.xml;hb=f85d380904ca6cfcc5d71d5efe44d6a4a673e2b1;hpb=96c9d88bad9a7d7d44bfb7f26c226df7ee9ddf26;

cmb69 commented 3 years ago

Okay, I see, but this is of limited usefulness, because git.php.net is no longer used for weeks, and it is unlikely that it'll be revived.

alfsb commented 3 years ago

On Mon, Apr 26, 2021 at 10:23 AM Christoph M. Becker < @.***> wrote:

Okay, I see, but this is of limited usefulness, because git.php.net http://git.php.net is no longer used for weeks, and it is unlikely that it'll be revived.

Well, it's about despair that revcheck.php still points to git.php.net, so used or not, revived or not, it may keep pointing there while git.php.net keeps providing some result.

André

cmb69 commented 3 years ago

Okay, I had a closer look, and this is a viable workaround for now, since GH apparently doesn't support single file comparisons. Thanks for your work!