search

php / doc-base

Tools for the PHP documentation
Other
343 stars 85 forks source link

Add a link entity for PHP source code reference #55

Closed stkeke closed 2 years ago

stkeke commented 2 years ago

PHP manual has a few cases referring to PHP source code file, and therefore add an external link entity to be used for this purpose.

Signed-off-by: Su, Tao tao.su@intel.com

stkeke commented 2 years ago

This final result of this patch look like this: image

stkeke commented 2 years ago

I am not quite familiar with translations (you mean translation to other language?) I guess that once we changed the definition of url.php.git.phpini in doc-base, all other language repos have to change accordingly. That's a bit effort.

This url.php.git.src is mainly for https://github.com/php/doc-en/pull/1340, which is still under discussion. I fully trust and respect maintainer's judgement to any of my PRs because you guys are the most experienced experts in PHP world. So, I rely on our maintainer to have the final word!

cmb69 commented 2 years ago

I am not quite familiar with translations (you mean translation to other language?) I guess that once we changed the definition of url.php.git.phpini in doc-base, all other language repos have to change accordingly. That's a bit effort.

Yes, I was referring to this. Not sure whether that would really a big deal for translators, though.

philip commented 2 years ago

Sorry to hijack and inspire yak shaving tasks to this PR but figured it's worth mentioning that the (now outdated) url.php.git.mirror "https://github.com/php/" entity exists and is used in a few places. While removing it isn't an option, replacing it and modifying the associated text is. Feel free to close this PR without doing so; just mentioning it for good measure.