search

php / doc-de

German translation of the PHP documentation
25 stars 42 forks source link

Remove XForms documentation (part of php/doc-en#3579) #177

Closed jimwins closed 1 month ago

jimwins commented 1 month ago

Removes the translation in advance of it being removed entirely.

cmb69 commented 1 month ago

Thank you! Before this can be merged, https://github.com/php/doc-en/pull/3601 needs to be merged, and then the EN-Revision for the modified file needs to be updated, and possibly other pending updates to that file need to be made.

jimwins commented 1 month ago

Updated the revision. The reason for going ahead and deleting features/xforms.xml now, in this and other translations, is so that when reference to it removed from doc-base/manual.xml.in it won't immediately break the build for all of those translations. In the (hopefully short) time between it being removed from the translations and from doc-en, the translations should just fall back to the English version.

jimwins commented 1 month ago

Looked in the wrong branch and thought this had been done. Still needs doing.

cmb69 commented 1 month ago

Maybe we should not update the EN-Revision here; there may have been other changes to this file in between (or haven't there any). Not sure what's best for the active translators; maybe @msamesch can comment?

jimwins commented 1 month ago

There were no other untranslated changes to that file, so chopping out that paragraph and updating the EN-Revision should bring it up to date. (I made PRs for every language, but only changed the EN-Revision if there were no other untranslated changes, was just doc-es and doc-it. The change without updating EN-Revision was merged to doc-es and doc-it is still pending for someone to deal with.)

msamesch commented 1 month ago

I forgot about this PR while I was waiting for the corresponding update in EN. Otherwise it's fine with me. Also meanwhile chapters/tutorial.xml was updated in c73ea82. Thanks for the update anyway.