search

php / pecl-file_formats-yaml

YAML-1.1 parser and emitter
https://pecl.php.net/package/yaml
MIT License
72 stars 33 forks source link

Fix build on PHP 7.3 #32

Closed dktapps closed 6 years ago

dktapps commented 6 years ago

fixes https://github.com/php/pecl-file_formats-yaml/pull/30#issuecomment-381415730

petk commented 6 years ago

Thanks for this... :+1: Bug report has been submitted here: https://bugs.php.net/bug.php?id=76522

remicollet commented 6 years ago

Please also add 7.1, 72 and nightly to .travis.xml file

BTW, on a local build, still 1 test failure

TEST 23/67 [tests/yaml_emit_007.phpt]
========DIFF========
001+ string(29) "---
001- string(56) "---
004+ c: *refid1
004- c: &refid1
005-   a: a
006-   b: b
007-   c: *refid1
========DONE========
FAIL yaml_emit - recursive structures [tests/yaml_emit_007.phpt]
dktapps commented 6 years ago

@remicollet I ran tests on Windows and there was a lot of noise there (due to newline issues \n vs \r\n, might need fixing separately), so I didn't notice that test failure 🙄 I'll take a look at it later when I can get on a linux machine.

petk commented 6 years ago

Note that there is a PR for PHP versions in Travis changes here #30 Redacted: And this PR addresses it also, sorry... Missed it.

remicollet commented 6 years ago

See PR #33 with an happy travis result \o/

remicollet commented 6 years ago

Fixed by PR #33 which is merged