search

php / pecl-networking-ssh2

Bindings for the libssh2 library
http://pecl.php.net/package/ssh2
Other
51 stars 58 forks source link

PHP 7.3 only compatibility #32

Closed Jan-E closed 6 years ago

Jan-E commented 6 years ago

This PR combines the two other PR's:

  1. Fixed PHP7 port. Restored commented reference counting. https://github.com/php/pecl-networking-ssh2/pull/30 by @dstogov

  2. Updates for php_url structure changes (make failed on 7.3). https://github.com/php/pecl-networking-ssh2/pull/31 by @DanielCiochiu

And it changes GC_REFCOUNT(p)++ into GC_ADDREF(p) cf https://github.com/php/php-src/blob/master/UPGRADING.INTERNALS#L81

Note the PR is for PHP 7.3 only.

remicollet commented 6 years ago

Sorry, I miss this one before working on the php_url stuff.

Can you please rebase ?