search

php / pecl-networking-ssh2

Bindings for the libssh2 library
http://pecl.php.net/package/ssh2
Other
51 stars 58 forks source link

Remove inline from php_ssh2_sftp_attr2ssb #36

Closed andypost closed 4 years ago

andypost commented 5 years ago

That were fixed in https://github.com/php/pecl-networking-ssh2/commit/073067ba96ac99ed5696d27f13ca6c8124986e74#diff-d0296647d3a59f029c56a9154f65ab01R52 But this inline still causing build issues

PS: related to https://github.com/alpinelinux/aports/pull/6226 and http://clang.llvm.org/compatibility.html#inline

glensc commented 5 years ago

@andypost can you finish this up? looks like one comment needs to be addressed

andypost commented 5 years ago

I will try to rebuild with static inline and report

andypost commented 5 years ago

For some reason travis does not fail on php 7.3 without patch https://travis-ci.org/php/pecl-networking-ssh2/builds/572224235

glensc commented 5 years ago

so, build passes, let's merge this (or https://github.com/php/pecl-networking-ssh2/pull/35) and get release ready for php 7.3!

glensc commented 5 years ago

how do you even install the unreleased versions with pecl?

Step 6/20 : RUN pecl install https://github.com/php/pecl-networking-ssh2/archive/master.tar.gz && echo "extension=ssh2.so" > 02_ssh2.ini
 ---> Running in 03f916f31070
PHP Warning:  Module 'xml' already loaded in Unknown on line 0
downloading master ...
Starting to download master (Unknown size)
.....done: 32,951 bytes
Validation Error: Version type <release> is not a valid version (1.2-dev)
Parsing of package.xml from file "/tmp/pear/temp/pearLFDPPP/pecl-networking-ssh2-master/package.xml" failed
Download of "https://github.com/php/pecl-networking-ssh2/archive/master.tar.gz" succeeded, but it is not a valid package archive
Invalid or missing remote package file
install failed
andypost commented 4 years ago

Is there a way to create new release?

langemeijer commented 4 years ago

I'm doing that. The 1.2 release is prepared in the repo, but I've bumped into an issue with the pecl uploading thingy. Should be solved soon.

glensc commented 4 years ago

any chance for creating git tags for each release too?

I'm willing to look up the closest git hashes for each tag if there's someone to pick them up and push to this repo.

langemeijer commented 4 years ago

I'm not exactly sure how this will improve your life, but to indulge you I've pushed the tags for all releases, and even removed a falsely create one from 2005.

langemeijer commented 4 years ago

The 1.2 release is now available through pecl: https://pecl.php.net/package/ssh2

keksa commented 4 years ago

@langemeijer The installation currently fails to download the archive with error 500, previous releases can be downloaded just fine:

Could not download from "https://pecl.php.net/get/ssh2-1.2.tgz", cannot download "pecl/ssh2" (File https://pecl.php.net:443/get/ssh2-1.2.tgz not valid (received: HTTP/1.0 500 Internal Server Error))

glensc commented 4 years ago

https://github.com/php/pecl-networking-ssh2/pull/36#issuecomment-532579749 by @langemeijer I'm not exactly sure how this will improve your life, but to indulge you I've pushed the tags for all releases, and even removed a falsely create one from 2005.

As I wrote:

as I'm trying to build this for php 7.3, and apparently applying only #36 is not enough, and not known what is the baseline from the last release as git tags are missing from the repository.

andypost commented 4 years ago

The only way to download release is visiting https://pecl.php.net/get/ssh2 (Latest tarball link)

keksa commented 4 years ago

@andypost This link on https://pecl.php.net/package/ssh2 targets https://pecl.php.net/get/ssh2-1.2.tgz and it gives err 500 Screenshot 2019-09-18 at 15 38 45

andypost commented 4 years ago

@keksa yes, it gives me 500 but the one from "Latest tarball" works for some reason

remicollet commented 4 years ago

https://bugs.php.net/bug.php?id=78560