search

php / pecl-networking-ssh2

Bindings for the libssh2 library
http://pecl.php.net/package/ssh2
Other
51 stars 58 forks source link

Fix compatibility with PHP 8.0 #42

Closed andypost closed 3 years ago

andypost commented 4 years ago

Ref https://github.com/php/php-src/commit/302933daea77663f5759b10accd1d0231393b24c

https://github.com/php/php-src/blob/master/UPGRADING.INTERNALS#L140

The zend_fcall_info no_separation flag has been removed, and separation is never allowed. If you wish to pass (or allow passing) arguments by reference, explicitly create those arguments as references using ZEND_MAKE_REF. This removal also affects call_user_function_ex(), which should be replaced by call_user_function().

andypost commented 4 years ago

Next is https://github.com/php/php-src/commit/ac4e0f0852ce780e143013ceff45067a172e8a83 + needs to fix running tests

No replacement, please use ZEND_ARG_INFO() with an explicit argument name instead.

php8 -dextension=modules/ssh2.so --ri ssh2
PHP Warning:  Missing arginfo for ssh2_forward_listen() in Unknown on line 0
PHP Warning:  Missing arginfo for ssh2_forward_accept() in Unknown on line 0

ssh2

SSH2 support => enabled
extension version => 1.2
libssh2 version => 1.9.0
banner => SSH-2.0-libssh2_1.9.0
andypost commented 4 years ago

Remaining warnings probably because of resources in 8+ are objects

remicollet commented 3 years ago

More commits needed (for 7.4+) in pr #44

andypost commented 3 years ago

Closing in favour of #44 and glad to get new release soon