php / pecl-networking-ssh2

Bindings for the libssh2 library
http://pecl.php.net/package/ssh2
Other
51 stars 59 forks source link

Fix #80729: ssh2_shell() streams are not stream_select()able #51

Closed cmb69 closed 3 years ago

cmb69 commented 3 years ago

On Windows, the socket type is not an int but rather SOCKET which is actually unsigned int on x86 and unsigned __int64 on x64. To cater to this type mismatch, PHP offers the portable php_socket_t (at least as of PHP 5.0.0). We use it for php_ssh2_session_data as well.


Note that this patch constitutes an ABI break, and as such likely needs to be postponed to the next major version. :(