ssh2: IS_CALLABLE_CHECK_SILENT

php / pecl-networking-ssh2

Bindings for the libssh2 library

http://pecl.php.net/package/ssh2

Other

51 stars 58 forks source link

ssh2: IS_CALLABLE_CHECK_SILENT #54

Closed kornrunner closed 3 years ago

kornrunner commented 3 years ago

Update check for PHP8

langemeijer commented 3 years ago

Ah yes.. I noticed this too. It stopped compilation for 8.0 because IS_CALLABLE_CHECK_NO_ACCESS has been removed.

Can you give your rationale on why it should be IS_CALLABLE_CHECK_SILENT? I reverted it back to the 0 value that this line of code had before. I released this as 1.3 too, but I'm happy to create a new release if needed.

pauci commented 3 years ago

Should the new release 1.3 actually work with PHP >= 8.0? I'm getting failed dependency constraint:

pecl/ssh2 requires PHP (version >= 7.0.0, version <= 8.0.0), installed version is 8.0.2

remicollet commented 3 years ago

package.xml is wrong, as it keep maximal allowed version to 8.0.0

langemeijer commented 3 years ago

Will fix now. package.xml in the tarball indeed is wrong

kornrunner commented 3 years ago

Thank you!