php / pecl-networking-ssh2

Bindings for the libssh2 library
http://pecl.php.net/package/ssh2
Other
51 stars 61 forks source link

file_get_contents('ssh2.exec://...') was always returning a blank string #8

Closed dakusan closed 8 years ago

dakusan commented 8 years ago

Set blocking to true for the exec wrapper stream, which fixes it

langemeijer commented 8 years ago

Is it safe to say that we could close this pull request because the fix introduces more problems than it solves? I won't merge this to the pecl repo then.

@dakusan Can you close this pull request? (I can merge patches to git.php.net but have no control over the github repo)

dakusan commented 8 years ago

Oops, sorry about that. I'm not completely convinced that this isn't the right path to take, but I'll defer to your judgement. I have too much else on my plate right now to play with this. Thanks for taking the time. Closing the ticket.