Incorrect `ReflectionClass::getNamespaceName` for anonymous class

[kubawerlos]

Description

The following code:

<?php

namespace Foo {
    interface InterfaceFoo {}
}

namespace Bar {
    new class implements \Foo\InterfaceFoo {};
}

namespace {
    foreach (get_declared_classes() as $class) {
        if (!str_contains($class, '@anonymous')) {
            continue;
        }
        echo 'Class: ', $class, PHP_EOL;
        echo 'Namespace: ', (new ReflectionClass($class))->getNamespaceName(), PHP_EOL;
    }
}

Resulted in this output:

Class: Foo\InterfaceFoo@anonymousD:\a\php-anonymous-class-namespace\php-anonymous-class-namespace\test.php:8$0
Namespace: Foo\InterfaceFoo@anonymousD:\a\php-anonymous-class-namespace\php-anonymous-class-namespace

at Windows and

Class: Foo\InterfaceFoo@anonymous/home/runner/work/php-anonymous-class-namespace/php-anonymous-class-namespace/test.php:8$0
Namespace: Foo

at Ubuntu

But I expected this output instead:

Class: Foo\InterfaceFoo@anonymousD:\a\php-anonymous-class-namespace\php-anonymous-class-namespace\test.php:8$0
Namespace: Bar

Reproduced at https://github.com/werlos/php-anonymous-class-namespace (see the only action there).

PHP Version

8.3.0

Operating System

No response

[iluuu1994]

Hi @kubawerlos. I don't understand, why do you expect backslashes for paths on Ubuntu? The slashes are not namespace separators, its a path appended to the class name to avoid naming conflicts of anonymous classes. The class name of anonymous classes is essentially an implementation detail.

Edit: Oh, sorry. I missed that this is talking about getNamespaceName, not the slashes.

[nielsdos]

This is because Windows paths use backslashes, but the function also uses backslashes to determine where to "cut off" the string: https://github.com/php/php-src/blob/ec79fc9d9c266e85b94fba46b1c347068f565d6f/ext/reflection/php_reflection.c#L5456-L5459

Tested on my Windows 10 VM I get the same behaviour as OP.

[nielsdos]

And getShortName is also messed up as it'll return "foo.php:8$0".

[iluuu1994]

Indeed. I think OP would also expect Unix to yield Bar, but because the name is prefixed with the parent class (or first implemented interface) rather than the namespace it's also wrong.

[nielsdos]

Okay, so fixing this would consist of two parts:

• Fix how a prefix is chosen such that the correct namespace is included in the name
• If on Windows, and ZEND_ACC_ANON_CLASS is set, check the position of @ and search for the backslash before that

WDYT?

[iluuu1994]

That sounds reasonable. namespace@anonymouspath:line$counter should do. I don't know what the point of including the parent class is.

[nielsdos]

I don't know what the point of including the parent class is.

72bd55902d1908857f47555ad69458861e1acd94

"This is intended to display a more useful class name in error messages and stack traces, and thus make debugging easier."

I guess it doesn't really matter that much, but I did find this.

[nielsdos]

@iluuu1994 How do you want to proceed here? I have a working Windows development environment and I already know how to tackle the second bullet point.

EDIT: or we could split the issue between us: 2nd bullet point for me and 1st for you? Just let me know so we at least don't do double work ;)

[iluuu1994]

@nielsdos However you want, I'll focus on something else tomorrow. I'm certainly not mad if you take care of either or both. ^^ I don't think this is high priority though.

[nielsdos]

Okay, will tackle this tomorrow.

[Wirone]

Let's code PHP like there's no tomorrow! 😀