php / php-src

The PHP Interpreter
https://www.php.net
Other
37.67k stars 7.7k forks source link

Fallback to using Certificate Authority from Windows Certificate Store #13601

Open Luc45 opened 4 months ago

Luc45 commented 4 months ago

Description

In PHP's current implementation, there is an inconsistency in how the language handles SSL/TLS certificate validation across different operating systems. This inconsistency primarily affects Windows users.

In this proof-of-concept, we can see the behavior clearly:

On Windows, the script does two requests:

  1. The first request without a CA file that fails and prints Request correctly failed without CA certificate (expected on Windows)
  2. A second request using the CA file from Mozilla that succeeds and prints Request succeeded with provided CA certificate

On Linux and Mac, it uses the O.S CA file, which prints Request succeeded without CA certificate (expected on Linux and macOS)

On Linux, it uses by default:

CAfile: /etc/ssl/certs/ca-certificates.crt
CApath: /etc/ssl/certs

On Mac, it uses:

CAPath: /usr/local/etc/openssl@3/certs

On Windows, both are blank:

CAfile: (empty)
CApath: (empty)

Which means that PHP doesn't have a fallback Certificate Authority file to validate HTTPS requests, which leads to issues such as these. The common solution for this problem for Windows users is to download a trusted CA file (such as from Mozilla), and update php.ini to use it:

This is a sub-optimal solution as it increases complexity for the average John Doe that just wants to do a network request against a HTTPS URL.

I think PHP in Windows could fallback to accessing the Windows Certificate Store, or bundle a trusted CA file, although this might get outdated.

Ayesh commented 4 months ago

Unlike Macos and Linux, Windows doesn't have a single file root CA file. That's why the ini values are empty in the first place.

We recently upped the minimum required Libcurl version to 7.61.0. There is support to use native Windows CA store in Libcurl 7.71 (https://curl.se/libcurl/c/CURLOPT_SSL_OPTIONS.html). It will need some work in the Curl extension, but I think this is the way to go. Probably easier to implement now with a not-so-distant minimum required version.

One alternative, bundling our own root CA list, is a big no-no in my opinion.