search

php / php-src

The PHP Interpreter
https://www.php.net
Other
38.15k stars 7.74k forks source link

Test curl_basic_008 can fail #13688

Closed andypost closed 3 months ago

andypost commented 7 months ago

Description

Used to build fresh 8.2.17 for Alpinelinux and get failed test, that's because it hit existing domain

Resulted in this output:

TEST 5030/16433 [ext/curl/tests/curl_basic_008.phpt]
========DIFF========
+ <!doctype html><html lang="en" class="is_adaptive" data-page-type="parking-crew"><head><meta charset="UTF-8"><meta name="robots" content="noindex"><meta name="robots" content="nofollow"><meta name="robots" content="noarchive"><meta property="og:site_name" content="www.65f08b3918ab1.65f08b3918ac3"><meta property="og:url" content="http://www.65f08b3918ab1.65f08b3918ac3/"><meta property="og:image" content="http://yourmine.ru/i/parking/glob_parking.png"><meta property="fb:app_id" content="280542925476675"><meta name="viewport" content="width=device-width,initial-scale=1"><meta name="parking" content="ape"><title>Срок регистрации домена&nbsp;www.65f08b3918ab1.65f08b3918ac3 истёк</title><link rel="stylesheet" media="all" href="/parking-crew.css"><link rel="stylesheet" href="http://i.cdnpark.com/themes/registrar/035524.css"><style>body {
+             background: #E5E5E5;
- %s resolve%s
- int(6)

Now sure how to prevent that in future, probably test should use .invalid domain instead of random www.65f08b3918ab1.65f08b3918ac3

PHP Version

PHP 8.2.17

Operating System

Alpinelinux

nielsdos commented 7 months ago

Simple, maybe stupid fix at https://github.com/php/php-src/pull/13693 I'd say: just point it to a domain PHP controls and we should be fine?

damianwadley commented 7 months ago

65f08b3918ab1.65f08b3918ac3 obviously isn't real - this is the DNS provider responding with the IP address of some generic host that can provide [something that pretends to be] a parked domain landing page. A non-existent *.php.net hostname, considering that PHP does not have a wildcard subdomain setup, may or may not get similar treatment...

nielsdos commented 7 months ago

may or may not get similar treatment...

I would expect that to be less the case when the domain exists and subdomain doesn't.

andypost commented 7 months ago

Yeah, looks like DNS-provider messing-up, or maybe docker in CI