NattyNarwhal
commented
4 days ago For php_network_connect_socket_to_host, I think the union should probably be = {0}'d, or actually set the fields, if they are important (Scope ID does matter with link-local, at least.). Snippet of the relevant code below:
union {
struct sockaddr common;
struct sockaddr_in in4;
#ifdef HAVE_IPV6
struct sockaddr_in6 in6;
#endif
} local_address;
int local_address_len = 0;
if (sa->sa_family == AF_INET) {
if (inet_pton(AF_INET, bindto, &local_address.in4.sin_addr) == 1) {
local_address_len = sizeof(struct sockaddr_in);
local_address.in4.sin_family = sa->sa_family;
local_address.in4.sin_port = htons(bindport);
memset(&(local_address.in4.sin_zero), 0, sizeof(local_address.in4.sin_zero));
}
}
#ifdef HAVE_IPV6
else { /* IPV6 */
if (inet_pton(AF_INET6, bindto, &local_address.in6.sin6_addr) == 1) {
local_address_len = sizeof(struct sockaddr_in6);
local_address.in6.sin6_family = sa->sa_family;
local_address.in6.sin6_port = htons(bindport);
}
}
#endif
#ifdef IP_BIND_ADDRESS_NO_PORT
{
int val = 1;
(void) setsockopt(sock, SOL_IP, IP_BIND_ADDRESS_NO_PORT, &val, sizeof(val));
}
#endif
if (local_address_len == 0) {
php_error_docref(NULL, E_WARNING, "Invalid IP Address: %s", bindto);
} else if (bind(sock, &local_address.common, local_address_len)) {
php_error_docref(NULL, E_WARNING, "Failed to bind to '%s:%d', system said: %s", bindto, bindport, strerror(errno));
}
nielsdos
Girgias
Description
Some of our tests when run under Valgrind seem to be leaking because of mistakes within php-src. I ran those tests while attempting to determine another issue, but those seem very unlikely related to my specific issue.
ext/standard/tests/network/bug74764.phptext/standard/tests/strings/strtr_with_reference.phptZend/tests/generators/errors/generator_extend_error.phptZend/tests/weakrefs/weakrefs_004.phptPHP Version
master
Operating System
No response