search

php / php-src

The PHP Interpreter
https://www.php.net
Other
38.23k stars 7.75k forks source link

Allow to build apache2 SAPI same time with other SAPIs #15523

Open andypost opened 2 months ago

andypost commented 2 months ago

Description

ATM distro builders need separate build pass to build apache2handler because of php.m4 macro PHP_SELECT_SAPI

It was discussed in https://bugs.php.net/bug.php?id=52419 but somehow it still disallowed

If I wanna add ZTS variation to Alpinelinux looks I need to build it all 4 times... maybe there's workaround?

https://github.com/php/php-src/blob/63841ba7cfc368398f9310b785298400f6b7b2d9/build/php.m4#L843-L859

andypost commented 2 months ago

@petk you're polishing build system for upcoming 8.4, maybe there's a chance to simplify it somehow?

Here's current state https://gitlab.alpinelinux.org/alpine/aports/-/blob/434979f6f88eac4b6252911d0c585e40931da1f4/testing/php84/APKBUILD#L332-350

petk commented 2 months ago

Hello, yes, confirming. This is one of the "features" that was added a long time ago to PHP build system. I'm not sure how this never got addressed yet. Probably it was simpler to do that and have limited build experience.

Currently there are several related issues here:

This is (will) be fixed in CMake-based PHP build system :D so I'm not sure yet if this can be done in Autotools just like that.

It was discussed in https://bugs.php.net/bug.php?id=52419 but somehow it still disallowed

^ This should be reopened and considered as a major bug. In my opinion, this is unacceptable "feature" in today's builds. Since this issue is now reported it supersedes the 52419 bug report.

cmb69 commented 2 months ago

https://github.com/php/php-src/actions/runs/10616580833/job/29427350747#step:5:582 (whispers: come to the dark side ;)

andypost commented 2 months ago

@cmb69 how come?! does it mean that issue resolved?

cmb69 commented 2 months ago

It is resolved on Windows for a long time (whispers again: come to the dark side ;)