php / php-src

The PHP Interpreter
https://www.php.net
Other
38.29k stars 7.76k forks source link

Revise ext/standard/tests/file test suite #16872

Open cmb69 opened 5 days ago

cmb69 commented 5 days ago

Description

Occasionally, there are still test conflicts, and a couple of tests are marked as obscure_filename conflicting. Furthermore, some of the tests do not necessarily clean up properly after execution (they unlink some created files during test execution only). Also, some tests appear to have POSIX and Windows variants, although that doesn't seem to be necessary. See e.g. #16722 and #16854.

Ideally, all tests should only create and delete files which either have the same base name as the test case, or are placed in a directory with the base name of the test case. Since this may lead to overlong paths, we may need to take some shortcuts there (possibly using shorter test case names).

In any way, this test suite should be cleaned up/improved.