search

php / php-tasks

Tasks that need doing. This is for php-src maintainers. The end-user bug tracker is at https://bugs.php.net/.
27 stars 6 forks source link

Consistent named param: Extension Tracker #23

Closed Girgias closed 3 years ago

Girgias commented 4 years ago

This is a tracker to see which extensions have been reviewed in regards to #16

Unresolved questions:

remicollet commented 3 years ago

Checked zip, consistency fixed in https://github.com/php/php-src/commit/dafc72cb33ea677cd0b3caffc8fe7bf510a4bf7c

remicollet commented 3 years ago

As a side note, this also means php documentation probably needs a big update, so the parameters name describe there matches actual one in 8

Done for zip in https://github.com/php/doc-en/commit/462e36980658cbed6b76f188038edc796ae379bc and https://github.com/php/doc-en/commit/002b7dd50a0cb86e965022610f08f240cadb6fcc

kocsismate commented 3 years ago

@remicollet Yes, we have already started working on (at least making it possible to) automatically generate function signatures for the manual.

And later we should change the parameter names in the descriptions as well.

cmb69 commented 3 years ago

And later we should change the parameter names in the descriptions as well.

That should be done as soon as the signatures are changed in the manual. :)

kocsismate commented 3 years ago

That should be done as soon as the signatures are changed in the manual. :)

True :) I messed up the timeline ^^ Should have said "afterwards" or "right after"

dtakken commented 3 years ago

Related PR to update the coding standards to include parameter names:

php/php-src/pull/5897

Crell commented 3 years ago

PR for pgsql: https://github.com/php/php-src/pull/6304

Waiting to see if it passes tests... :sweat_smile:

nikic commented 3 years ago

I believe we're done here.