search

php / php-tasks

Tasks that need doing. This is for php-src maintainers. The end-user bug tracker is at https://bugs.php.net/.
27 stars 6 forks source link

ext/zip/tests/bug53885.phpt fails on 7.4 on macos #8

Closed nikic closed 4 years ago

nikic commented 4 years ago

The test ext/zip/tests/bug53885.phpt fails on PHP 7.4 (but not master!) on macos with the diff:

001+ Warning: ZipArchive::locateName(): Invalid or uninitialized Zip object in /Users/runner/runners/2.170.1/work/1/s/ext/zip/tests/bug53885.php on line 7 002+ 003+ Warning: ZipArchive::statName(): Invalid or uninitialized Zip object in /Users/runner/runners/2.170.1/work/1/s/ext/zip/tests/bug53885.php on line 8

@remicollet Do you know why this would happen on 7.4 only? It started happening only recently.

remicollet commented 4 years ago

This should not happen. I notice the same error with libzip 1.7.0 which is totally broken

Which libzip version is it ?

In short libzip 1.7.0 don't have any of the LIBZIPVERSION* macro, which make its use impossible

libzip 1.7.1 is OK.

remicollet commented 4 years ago

Perhaps we can add

#if ! defined (LIBZIP_VERSION_MAJOR)
#error Borken libzip update to 1.7.1
#endif
nikic commented 4 years ago

@remicollet Thanks for the quick reply! I checked the build log and it does indeed say:

Warning: libzip 1.7.0 is already installed and up-to-date To reinstall 1.7.0, run brew reinstall libzip

Probably we need to force macos CI to update this package in some way.

remicollet commented 4 years ago

For memory we have same issue with 1.3.1

And:

nikic commented 4 years ago

Proposed fix: https://github.com/php/php-src/pull/5737

remicollet commented 4 years ago

Sorry, was working on another fix (at configure time, which can be better), so miss your PR. BTW, both make sense

nikic commented 4 years ago

Fixed by:

Thanks for your help @remicollet!