php / web-doc

http://doc.php.net
33 stars 85 forks source link

Change directory that doc-en is cloned into #15

Closed tiffany-taylor closed 3 years ago

tiffany-taylor commented 3 years ago

The reasoning for this change is so that it's easier to start working with the docs with fresh clones from github. doc-base/configure.php expects an en directory, but if I clone doc-en repo from github, I have a doc-en directory with manual contents in the doc-en folder. This requires further renaming and directory juggling to get the tooling to work together nicely. By cloning into doc-en/en, this leaves a doc-en base directory that can contain en for the doc-en repo, phd and doc-base, then the rest of the tutorial instructions work nicely.

salathe commented 3 years ago

This change is only a small improvement to the instructions: those instructions would be much better off being reviewed and amended as a whole rather than making isolated "improvements" (the SVN to Git changes are a perfect example of what not to do).

@tiffany-taylor - would you be willing to spend some more time on that?

Issues that would remain, to name a but few:

My suggestions for this page:

tiffany-taylor commented 3 years ago

I'll step through it tomorrow and give an attempt at rewriting it.