search

php / web-doc

http://doc.php.net
33 stars 85 forks source link

Fix file size error #41

Closed mowangjuanzi closed 3 weeks ago

mowangjuanzi commented 1 year ago

http://doc.php.net/revcheck.php?p=misstags&lang=zh

The value of the 'zh' column is the value read from the English version.

This is wrong.

nilgun commented 1 year ago

Using en values for dimension is based on the assumption that the translations will have approximately the same dimensions. Because the size calculation is done very roughly. File sizes were collected from English files without distinction between translated and untranslated. When I tested your change, a division by zero error occurred while calculating the file summary table.

This error occurs, also for the Chinese file summary in the recent translation state. You can also test it yourself.

I think these modifications are unnecessary. Don't try to fix it.

jimwins commented 3 weeks ago

Yeah, this isn't even really useful information, better to just remove it from the table. PR #53 will do that.