search

php / web-pecl

The PECL website
http://pecl.php.net
Other
32 stars 31 forks source link

upd jpgraph to 4.2.0 (see https://jpgraph.net/news/) #11

Closed Gemorroj closed 5 years ago

Gemorroj commented 6 years ago

test on php 7.1

petk commented 5 years ago

Thank you for the pull request @Gemorroj

Yes, the jpgraph library definitely needs an upgrade here and it seems this is a good way to go. I just haven't merged this one yet because I need to fully test all other parts of this web app... We might even enable composer one day and simplify the dependencies. So, thank you for your patience with this one. I'll speed up the other parts...

petk commented 5 years ago

Applied via 91b6d68d6ddcf8aac514212bab930db59254ec92 and upgraded to jpgraph library 4.2.5 with some unused files omitted (flags dat files, themes, docs...).

Thank you for waiting so long. I guess we just needed to upgrade entire site in the meantime to be able to do this step :sweat_smile: yet the work is far from finished. Installing Composer dependencies in production is not something utilized yet, HTML templates need upgrades, better OOP, more tests, and most of all migration to PDO/something will be also required since the DB package is outputting a lot of warnings on PHP 7.3...

In the next commits and discussions...

php-pulls commented 5 years ago

Comment on behalf of petk at php.net:

Applied and closing.

Gemorroj commented 5 years ago

Thank you for the information. I'm actually monitoring your contribution to the project)