php / web-php

The www.php.net site
http://www.php.net
Other
844 stars 538 forks source link

Convert homepage hero section styles to use BEM methodology #1102

Open lhsazevedo opened 3 days ago

lhsazevedo commented 3 days ago

Description

The homepage hero section currently does not follow the BEM (Block Element Modifier) methodology that has been partially adopted in newer pages, such as the thanks page. The upcoming navbar and search modal will also follow BEM conventions. The hero section was initially implemented in PR #459, but now needs to be updated to align with these conventions.

Task

Update the CSS and structure of the homepage hero section to match the BEM conventions used elsewhere. Only the relevant portions of index.php and styles/home.css should be updated. Additionally, the visual tests references to the hero classes will need to be updated.

Example Conversion

Here’s an example to guide you in converting a class:

Current class:

.hero-btn-primary { ... }

Converted to BEM:

.hero__btn--primary { ... }

In this example:

Steps

  1. Clone the repository and navigate to the homepage code.
  2. Refactor the CSS classes in the hero section using the BEM naming convention. Focus only on the hero-related classes.
  3. Ensure the CSS in styles/home.css follows BEM principles.
  4. Update the relevant visual tests where hero classes are used.
  5. Test the changes to ensure the styling and visual tests remain consistent.

Resources

Good first issue for

Feel free to ask questions if you need any help!

lhsazevedo commented 2 days ago

@saundefined Can you add hacktoberfest and good first issue labels to this issue?

saundefined commented 2 days ago

@saundefined Can you add hacktoberfest and good first issue labels to this issue?

done, thanks for the proposal!

nafisreza commented 1 day ago

/assign

lhsazevedo commented 1 day ago

@nafisreza Sure, go ahead! Someone will assign this to you shortly.

If you decide not to work on it, please let us know so that someone else can take it up.

nafisreza commented 1 day ago

Thanks @lhsazevedo I am starting to work on this.