search

php / web-rmtools

The PHP release management tools
13 stars 22 forks source link

Support extensions with config.w32 in subfolder #13

Closed cmb69 closed 4 years ago

cmb69 commented 4 years ago

Some extensions have the actual extension code in a subfolder of the toplevel package folder, and as such can't currently be built. For instance, xhprof has xhprof-x.y.z/extension/config.w32, but we only check for xhprof-x.y.z/config.w32 and config.w32.

Changing PeclExt::tmp_extract_path to point to the subfolder which contains ' config.w32` wouldn't work, though, because then the folders in package.xml won't match anymore. Therefore, we attempt to copy the whole subfolder one level up, and resume the build process.

cmb69 commented 4 years ago

@weltling, I temporarily used this patch to build https://windows.php.net/downloads/pecl/snaps/xhprof/2.1.4/ – results look good.

cmb69 commented 4 years ago

Applied as 560a116e6846c13a693a9ea221dda0c627da6fd7. Thanks!