search

php / web-rmtools

The PHP release management tools
13 stars 22 forks source link

Update instantclient to 19_9 for snaps #18

Closed shivammathur closed 2 years ago

shivammathur commented 2 years ago

Update instantclient to 19_9 for snaps to match stable builds.

shivammathur commented 2 years ago

@cmb69

I wasn't sure, so I changed it for all versions, but if it can only be changed for only newer versions let me know. Will update the PR.

cmb69 commented 2 years ago

Thank you for the PR! I don't think we should change that for PHP 7 versions, since the release versions will still use 12_1, and we shouldn't change that that late in the release cycle (PHP-7.4 enters security mode in a few weeks).

We can change that for PHP 8, but does anybody even build snapshots with rm-tools? If you do, updating would be fine. :)

shivammathur commented 2 years ago

@cmb69 Updated the PR to change only for PHP 8.0 and above.

cmb69 commented 2 years ago

Thanks!