search

php / web-rmtools

The PHP release management tools
13 stars 22 forks source link

Disable ext/interbase #7

Closed cmb69 closed 5 years ago

cmb69 commented 5 years ago

Commit bd73607 of php-src[1] broke the ext/ibase build; following Joe's reasoning[2] we disable the ext/interbase builds (at least for now).

[1] http://git.php.net/?p=php-src.git;a=commit;h=bd73607b9e4811e7caa9d2ff4d227626ffd35dab [2] https://github.com/php/php-src/pull/3976#issue-263815945

weltling commented 5 years ago

Indeed, TS build is broken now,

Thanks.

cmb69 commented 5 years ago

It seems that NTS is broken as well. From task-phpmaster-nts-windows-vc15-x64-2019-03-26_3-15-01.03.log:

ibase_events.obj : error LNK2001: unresolved external symbol TSRMLS_FETCH_FROM_CTX
ibase_events.obj : error LNK2001: unresolved external symbol TSRMLS_SET_CTX
C:\php-snap-build\obj-x64\nts-windows-vc15-x64\Release\php_interbase.dll : fatal error LNK1120: 2 unresolved externals
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.15.26726\bin\HostX64\x64\link.exe"' : return code '0x460'

Should I merge this PR?

weltling commented 5 years ago

@cmb69 yes, please lets disable interbase for now.

Thanks.

cmb69 commented 5 years ago

Applied as fe29aaffc7f766df4cf9cd346ffd4467fe8a3e06.