search

phpBBSEO / usu

Ultimate SEO URL
32 stars 25 forks source link

CSS hover effect breaks on prosilver based style #93

Closed forkless closed 8 years ago

forkless commented 9 years ago

When using the PBTech style the hover effect for the post buttons/icons stops working when USU is enabled.

Eg. http://dev2.forkless.com/announcements/welcome-to-phpbb3-t1.html

The quote button on the post should not be visible until mouse over.

fhemberger commented 9 years ago

I think I found the bug here: https://github.com/phpBBSEO/usu/blob/master/styles/all/template/phpbb_seo.js#L69

if (phpbb_seo.ext_classes) {
    var extclass = new RegExp("(^|\s)(" + seo_ext_classes + ")(\s|$)");
}

should be

if (phpbb_seo.ext_classes) {
    var extclass = new RegExp("(^|\s)(" + phpbb_seo.ext_classes + ")(\s|$)");
}
forkless commented 9 years ago

Doesn't seem to eleviate the issue for me, unfortunately.

fhemberger commented 9 years ago

Bummer, thought the script was manipulating CSS classes, but your issue still exists with JS disabled.

forkless commented 9 years ago

Thanks for trying never the less ^^