Close inline @internal only with one brace

phpDocumentor / fig-standards

Standards either proposed or approved by the Framework Interop Group

http://www.php-fig.org/

Other

361 stars 85 forks source link

Close inline @internal only with one brace #135

Closed malkusch closed 5 years ago

malkusch commented 8 years ago

Terminating inline @internal with two braces is confusing and inconsistent (see also phpDocumentor/phpDocumentor2#1530). Please consider not doing so in the PSR. Instead deprecate that behaviour in existing implementations and support a consistent behaviour with just one single closing brace.

Regarding the current usage of the inline tag: I randomly downloaded 7844 packages from composer (out of totally 104937) and found 24 usages. I am confident that this change affects only 0,3% of all users.

malkusch commented 8 years ago

Sorry, I just discovered #80. Please let reason prevail and deprecate the old behaviour.

ashnazg commented 5 years ago

This repo is outdated... please get a new fork from https://github.com/php-fig/fig-standards for future contributions.

This does still need to be discussed in the FIG repo, so please open a new PR there. Please link back to #80 so that the original discussion is easily accessible.

ashnazg commented 5 years ago

Rather than working against FIG repo, I have now updated this phpDoc fork, so we can resume working here.

Please update your fork of this repo, and update this PR to resolve its conflicts.