search

phpDocumentor / fig-standards

Standards either proposed or approved by the Framework Interop Group
http://www.php-fig.org/
Other
361 stars 85 forks source link

Revised definitions of @api and @internal #158

Closed mindplay-dk closed 5 years ago

mindplay-dk commented 5 years ago

As proposed and discussed here:

https://groups.google.com/d/msg/php-fig/tix3-i6YCQQ/Ww_uO-LCEwAJ

Note that I've removed the inline variant from the description - per it's revised definition as a visibility modifier, using it inline doesn't make any sense.

If approved, this voids #135.

ashnazg commented 5 years ago

Removing the inline option does take away one of the probably irreconcilable points of contention regarding the double-closing-brace. I can live with that being a "phpDocumentor feature" instead :+1:

ashnazg commented 5 years ago

Ping @ondrejmirtes @muglug @neuro159 for reviews.

muglug commented 5 years ago

cc @erunion for opinions

ashnazg commented 5 years ago

@GaryJones , you still X on your review?

@muglug @ondrejmirtes @neuro159 , anything to add?

ashnazg commented 5 years ago

@mindplay-dk , please reissue these changes as a new pull request at the FIG repo itself... my apologies for having to do so.

ashnazg commented 5 years ago

Absorbed these changes in on https://github.com/php-fig/fig-standards/pull/1118