search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
734 stars 268 forks source link

Allow ajax page links to have a title #1002

Closed bramley closed 3 months ago

bramley commented 8 months ago

Description

Allow ajax page links to have a title, defaulting to the link description. The title is shown when hovering over the link.

Currently an ajax link has a misleading title attribute. The title is set to that for the target page, but the link is always for a specific action on that page. See the screenshot for the Generate link.

This change adds an optional $title parameter to the PageLinkAjax() function then uses that or the $desc parameter for the call to PageLink2(). This allows the calls to PageLinkAjax() to be updated later to have a meaningful title when needed.

Related Issue

Screenshots (if appropriate):

image

michield commented 6 months ago

Didn't test, but looks fine

phpListDockerBot commented 3 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-15-release-candidate-is-available-for-testing/9473/1

phpListDockerBot commented 3 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-15-has-been-released/9495/1