search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
744 stars 269 forks source link

Remove redundant upgrade steps #1020

Closed bramley closed 6 months ago

bramley commented 7 months ago

Description

The upgrade process rejects an attempt to upgrade when the current version is earlier than 3.2.0. phplist moved to using UTF-8 before 3.2.0 so any database that is being upgraded is already UTF-8. The step to convert the tables again looks to be unnecessary.

Also, a group of table changes are commented as applying after 2.11.7, so those too can be removed as they have already been included in the database structure.

Also, to avoid any confusion, issue the message about assigning UUIDs only when there are some to assign.

Related Issue

Screenshots (if appropriate):

bramley commented 7 months ago

Removed a few more upgrade steps that apply to databases prior to 3.2.0. If someone upgrades a very old database then they have to go to 3.2.0 first, and that version's upgrade will apply these changes. Databases after 3.2.0 will not have the problems.

michield commented 7 months ago

Reviewed the code, didn't test, but looks fine

phpListDockerBot commented 5 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-15-release-candidate-is-available-for-testing/9473/1

phpListDockerBot commented 5 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-15-has-been-released/9495/1