search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
734 stars 268 forks source link

use the list order, even when grouping by category #1025

Closed michield closed 3 months ago

michield commented 4 months ago

Description

When listing lists grouped by category, still use the listorder for the order, and not the category

Related Issue

Screenshots (if appropriate):

bramley commented 4 months ago

What is the problem with the current behaviour? The ordering by category is needed so that when the subscribe page option "Display lists in labelled categories" is used the categories are displayed in ascending order. Without that they will be in an arbitrary order. Within each category the lists will be in ascending order of the order field. Here is an example image

then just change the order field for one list and the order of showing the categories changes image

michield commented 4 months ago

Yes, but if you have this setting:

Category: A, Z

and lists A1 listorder 5 Z1 listorder 1

Then it'll list

Instead, you'd want it to be

I tested this, and it works fine if you take out the order by category

bramley commented 4 months ago

This is just a difference of expectation as I would expect the categories to be displayed in ascending alphabetical order. People might have named the categories with that in mind so this change might be be a surprise. The original issue is https://github.com/phpList/phplist3/pull/426

michield commented 4 months ago

I think it makes more sense to allow control of the listing with the list order. We can mention it in the release notes, so that people are aware. All the examples in #426 have categories listed in alphabetical order. With this change you can achieve that, but you can also have a different order if you want to, so that makes it more flexible.

phpListDockerBot commented 3 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-15-release-candidate-is-available-for-testing/9473/1

phpListDockerBot commented 3 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-15-has-been-released/9495/1