search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
744 stars 269 forks source link

Allowing subscribers to be filtered by confirmed and/or blacklisted #1030

Closed lwcorp closed 6 months ago

lwcorp commented 7 months ago

Description

Added support to filter by confirmed and/or non blacklisted - and not just by unconfirmed and/or blacklisted, so now all statues are supported for filtering and not just half of which. Of course, I've made sure the checkboxes don't allow to choose both unconfirmed and confirmed at the time time or likewise blacklisted and not blacklisted.

Screenshots (if appropriate):

image

michield commented 7 months ago

Exactly. The way translations work (or at least are supposed to) is as follows:

  1. you write a string s('This is some text that is new and not translated yet')
  2. this is then displayed in all languages as the English text
  3. it is picked up by the translation system (this is the bit we need to check, but that's the theory)
  4. it can then be translated
  5. once the translation is there, it will show in the language of choice

So, as we changed terminology many years ago from "users" to "subscribers", we should use "subscribers" in any new texts that are added to the app.

michield commented 7 months ago

You can see it in your own screenshot. The old texts use "subscribers" and your new strings use "users"

michield commented 6 months ago

I think this one can be merged

phpListDockerBot commented 5 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-15-release-candidate-is-available-for-testing/9473/1

phpListDockerBot commented 5 months ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-15-has-been-released/9495/1