search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
746 stars 269 forks source link

Update CKEditor, Common and Updater plugins #971

Closed bramley closed 1 year ago

bramley commented 1 year ago

Description

Update the composer.lock file to use the latest CKEditor, Common and Updater plugins.

Related Issue

Screenshots (if appropriate):

michield commented 1 year ago

Looks like that makes us PHP7.4 incompatible. In a way that's fine as 7.4 is EOL now, but I think our Docker builds are still using 7.4, so we'd need to update that.

bramley commented 1 year ago

Seems to be caused by some dependencies in Common Plugin requiring php 8+. But I only use those packages when I know that the php version is 8+ so it is kind of a false negative.

I wouldn't want to make php 8+ a hard requirement for using Common Plugin. I only recently made php 7 a requirement.

bramley commented 1 year ago

I have removed the packages that require php 8+, and now the CI test for php 7.4 is successful, but those for php 7.2 and 7.3 still fail but for other dependencies. Maybe there is no need to run the tests for php 7.2 and 7.3?

michield commented 1 year ago

Yes, the 7.2 and 7.3 have been failing for quite some time. I kept them in for reference, but we can remove them soon.

phpListDockerBot commented 1 year ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1

phpListDockerBot commented 1 year ago

This pull request has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1