Closed bramley closed 12 months ago
not tested, but looks fine to me
This pull request has been mentioned on phpList Discuss. There might be relevant details there:
https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1
This pull request has been mentioned on phpList Discuss. There might be relevant details there:
https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1
Description
When editing a boolean item on the Settings page, such as "Send notifications about subscribe, update and unsubscribe", the select list of Yes and No should show the current value but shows Yes when the current value is actually No. The code to select No is now incorrect due to php 8 being stricter about comparisons.
The value for a boolean seems to be "1" for true and an empty string for false. Previously
$value == 0
would also be true when $value is an empty string.Related Issue
Screenshots (if appropriate):