search

phpList / phplist3

Fully functional Open Source email marketing manager for creating, sending, integrating, and analysing email campaigns and newsletters.
https://www.phplist.org
GNU Affero General Public License v3.0
744 stars 269 forks source link

Fix certain PR checks that always fail #997

Open lwcorp opened 1 year ago

lwcorp commented 1 year ago

If someone tries to send a PR to your code, two commit checks always fail.

Steps to reproduce

  1. Edit a file or create a new one.
  2. Commit it.
  3. Send a PR.

Expected result Pass all checks.

Actual outcome The second and third checks from the end (7.2 and 7.3) always fail. You can see them for further details in every open PR. The important part is it has nothing to do with the PR, but presented like it is (unless one clicks Details and reads carefully).

image

michield commented 11 months ago

yes, that's why they are marked to "allow to fail". They fail on composer dependencies. We'll take them out soon

lwcorp commented 11 months ago

Where does it show "allow to fail"?

michield commented 11 months ago

image

lwcorp commented 11 months ago

Do only admins see it?

michield commented 11 months ago

Ah, don't know. Can you see it here? https://github.com/phpList/phplist3/actions/runs/6760239013

Also, the overall run has a blue tick, as opposed to a red one when all of them fail https://github.com/phpList/phplist3/actions

lwcorp commented 11 months ago

Some actions there have a fail icon and some "just" a warning.

In #994 for example to know it's okay not to pass some of these tests?

michield commented 9 months ago

This is now ready for review in #1004