search

phpList / rest-api

This module is the REST API for phpList, powered by phpList 4
https://www.phplist.com/
GNU Affero General Public License v3.0
22 stars 12 forks source link

[FEATURE] POST subscriptions route #129

Open macolu opened 4 years ago

macolu commented 4 years ago

Summary

Add new endpoint to add a member to a list. Fix #118

Not sure this is the way you would have done it. Anyway, I had to implement it for an urgent need, so here it is :-)

Unit test

Integration tests added.

Code style

No code style errors according to phpcs.

Other Information

Code uses methods on Repositories that are not declared with "@method" annotations. I can make another PR on Core to add missing annotations if you want.

xh3n1 commented 3 years ago

Could you rebase against master, please @macolu? :)

macolu commented 3 years ago

@xh3n1 done :)

ramonfincken commented 3 years ago

Confirmed working to add a subscriber to a single list.

ramonfincken commented 3 years ago

It has been a year since the start of this PR. What needs to be done to get it into rest-api core ? @macolu @xh3n1

macolu commented 3 years ago

I'm not part of the team, so I can't go any further...

nfebe commented 3 years ago

@michield Can we look into this?

hurricaneop commented 2 years ago

@michield Can we look into this?

you need to clear cache in order to get the new /subscriptions to be recognized