search

phpactor / coc-phpactor

Phpactor CoC Extension
https://github.com/phpactor/phpactor
MIT License
28 stars 3 forks source link

About composer version and phpactor holding for tag #26

Closed dave2309 closed 2 years ago

dave2309 commented 2 years ago

Hi there,

First of all thank you very much for this, I am using php-action/LSP for quite some time and it is quite ok, even having some trouble having LSP 100% cpu kind of situation. Regarding the last statement, I was wondering if some updates were/are just needed to be apply in order to fix my few issues. Then here is my question, because I don't think that is really an issue. I am using vim 

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 10 2022 08:40:37)
Included patches: 1-4929
Modified by team+vim@tracker.debian.org
Compiled by team+vim@tracker.debian.org

On ubuntu focal.

Using vim-plug to manage the vim plugins.

Thanks in advance for clarification David

dantleech commented 2 years ago

so the latest phpactor is no longer has the bin/phpactor extension:update as it no longer has an exension-manager, so also no composer 1 usage.

the "pending" updates reflects the lastet changes, not sure what's going on there.

but basically master branch is a lightyear ahead of the last tagged version, if you depend on master instead fo the latest tag it should be "fine". Closing but can continue discussion here.

dave2309 commented 2 years ago

Thanks @dantleech for the explanation.

Still a bit confused about how should I integrate phpactor with lsp (coc) and vim. Would you mind clarify this if possible?

dave2309 commented 2 years ago

Well I changed the line 

Plug 'phpactor/phpactor', {'for': 'php', 'tag': '*', 'do': 'composer install --no-dev -o'}

by 

Plug 'phpactor/phpactor', {'for': 'php', 'branch': 'master', 'do': 'composer install --no-dev -o'}

It seems that I don't have the composer v1 lines And actually much quicker to upgrade. I guess I should be good

dave2309 commented 2 years ago

After upgrading I have those lines 

Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Package operations: 1 install, 24 updates, 42 removals
  - Removing symfony/finder (v5.4.3)
  - Removing seld/phar-utils (1.2.0)
  - Removing seld/jsonlint (1.8.3)
  - Removing phpactor/worse-reflection-extension (0.2.5)
  - Removing phpactor/worse-reflection (0.4.7)
  - Removing phpactor/worse-reference-finders (0.2.6)
  - Removing phpactor/worse-reference-finder-extension (0.1.6)
  - Removing phpactor/text-document (1.2.4)
  - Removing phpactor/source-code-filesystem-extension (0.1.5)
  - Removing phpactor/source-code-filesystem (0.1.8)
  - Removing phpactor/rpc-extension (0.2.4)
  - Removing phpactor/reference-finder-rpc-extension (0.1.5)
  - Removing phpactor/reference-finder-extension (0.1.7)
  - Removing phpactor/reference-finder (0.1.6)
  - Removing phpactor/php-extension (0.1.1)
  - Removing phpactor/path-finder (0.1.1)
  - Removing phpactor/name-specification (0.1.1)
  - Removing phpactor/logging-extension (0.3.4)
  - Removing phpactor/language-server-phpactor-extensions (0.5.3)
  - Removing phpactor/language-server-extension (0.6.4)
  - Removing phpactor/indexer-extension (0.3.3)
  - Removing phpactor/file-path-resolver-extension (0.3.4)
  - Removing phpactor/file-path-resolver (0.8.3)
  - Removing phpactor/extension-manager-extension (0.8.5)
  - Removing phpactor/docblock (0.3.5)
  - Removing phpactor/console-extension (0.1.6)
  - Removing phpactor/config-loader (0.1.2)
  - Removing phpactor/composer-autoloader-extension (0.2.3)
  - Removing phpactor/completion-worse-extension (0.2.3)
  - Removing phpactor/completion-rpc-extension (0.2.3)
  - Removing phpactor/completion-extension (0.2.5)
  - Removing phpactor/completion (0.4.6)
  - Removing phpactor/code-transform-extension (0.2.2)
  - Removing phpactor/code-transform (0.4.3)
  - Removing phpactor/code-builder (0.4.3)
  - Removing phpactor/class-to-file-extension (0.2.2)
  - Removing phpactor/class-mover (0.2.0)
  - Removing justinrainbow/json-schema (5.2.11)
  - Removing composer/spdx-licenses (1.5.6)
  - Removing composer/semver (1.7.2)
  - Removing composer/composer (1.10.25)
  - Removing composer/ca-bundle (1.3.1)
  - Upgrading symfony/polyfill-ctype (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading amphp/amp (v2.6.1 => v2.6.2): Extracting archive
  - Installing composer/pcre (1.0.1): Extracting archive
  - Upgrading composer/xdebug-handler (1.4.6 => 2.0.5): Extracting archive
  - Upgrading symfony/polyfill-php72 (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading symfony/polyfill-mbstring (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading twig/twig (v2.14.11 => v2.14.13): Extracting archive
  - Upgrading psr/container (1.1.1 => 1.1.2): Extracting archive
  - Upgrading jetbrains/phpstorm-stubs (v2021.3 => dev-master 4b95f4f): Extracting archive
  - Upgrading monolog/monolog (1.26.1 => 1.27.0): Extracting archive
  - Upgrading webmozart/glob (4.4.0 => 4.5.0): Extracting archive
  - Upgrading phpactor/class-to-file (0.4.1 => dev-master e9b7022): Extracting archive
  - Upgrading phpactor/map-resolver (1.4.0 => 1.5.0): Extracting archive
  - Upgrading thecodingmachine/safe (v1.1.3 => v1.3.3): Extracting archive
  - Upgrading symfony/polyfill-php80 (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading symfony/polyfill-php81 (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading phpactor/language-server (1.1.2 => 2.2.0): Extracting archive
  - Upgrading symfony/polyfill-intl-normalizer (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading symfony/polyfill-intl-grapheme (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading symfony/deprecation-contracts (v2.5.0 => v2.5.1): Extracting archive
  - Upgrading symfony/service-contracts (v2.5.0 => v2.5.1): Extracting archive
  - Upgrading symfony/polyfill-php73 (v1.24.0 => v1.25.0): Extracting archive
  - Upgrading symfony/console (v5.4.3 => v5.4.7): Extracting archive
  - Upgrading symfony/filesystem (v5.4.3 => v5.4.7): Extracting archive
  - Upgrading symfony/process (v4.4.37 => v5.4.7): Extracting archive
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
Generating optimized autoload files
Class Phpactor\Extension\LanguageServer\Tests\ridge\Converter\LocationConverterTest located in ./lib/Extension/LanguageServerBridge/Tests/Converter/LocationConverterTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Phpactor\Extension\LanguageServerPsalm\Model\Excepteion\PsalmProcessError located in ./lib/Extension/LanguageServerPsalm/Model/Excepteion/PhpstanProcessError.php does not comply with psr-4 autoloading standard. Skipping.
Class Phpactor\ClassMover\Tests\Adapter\TolerantParser\Example5Interface located in ./lib/ClassMover/Tests/Adapter/TolerantParser/examples/Example5.php does not comply with psr-4 autoloading standard. Skipping.
Class Phpactor\ClassMover\Tests\Adapter\TolerantParser\ExampleTrait located in ./lib/ClassMover/Tests/Adapter/TolerantParser/examples/Example6.php does not comply with psr-4 autoloading standard. Skipping.
Class Phpactor\ClassMover\Tests\Adapter\TolerantParser\Example7 located in ./lib/ClassMover/Tests/Adapter/TolerantParser/examples/Example7.php does not comply with psr-4 autoloading standard. Skipping.
Class Phpactor\WorseReflection\Tests\Inference\TestAssertWalker located in ./lib/WorseReflection/Tests/Inference/TestAssertResolver.php does not comply with psr-4 autoloading standard. Skipping.
32 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> bin/phpactor config:json-schema phpactor.schema.json

Would you mind confirm that it should be upgraded as it should?

Dave

dantleech commented 2 years ago

yes that looks good :+1: :)

dantleech commented 2 years ago

need to tag phpactor, the current version still has some more or less big issues but nothing to stop using it on a day to day basis.

dave2309 commented 2 years ago

@dantleech thanks so much. You can ping me if you need some specific testing or so... Will keep in touch here, if found something not going well. Anyway,

Have a very nice day.