search

phpactor / coc-phpactor

Phpactor CoC Extension
https://github.com/phpactor/phpactor
MIT License
28 stars 3 forks source link

Add tslib@^2.0.0 dependency #4

Closed premyslruzicka closed 4 years ago

premyslruzicka commented 4 years ago

The extension didn't work in my Neovim until I have manually added the tslib dependency.

Error on createExtension coc-phpactor from ~/.config/coc/extensions/node_modules/coc-phpactor/lib/extension.js Error: Cannot find module 'tslib'.

dantleech commented 4 years ago

Thanks, I see that https://github.com/marlonfan/coc-phpls/blob/master/package.json also includes this dep - I guess it was available from another plugin on my install.

dantleech commented 4 years ago

Published new version.

dantleech commented 4 years ago

Seems I didn't publush the new version, and just spent an hour learning how to debug this extension to discover this was the issue.:D I have publshed the new version now 1.0.3.