phpactor / coc-phpactor

Phpactor CoC Extension
https://github.com/phpactor/phpactor
MIT License
28 stars 3 forks source link

Symbol discovery #5

Closed rosmanov closed 2 years ago

rosmanov commented 4 years ago

It would be awesome if you could implement symbol discovery feature as in https://github.com/marlonfan/coc-phpls/

dantleech commented 4 years ago

What does it do? https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight ?

rosmanov commented 4 years ago

@dantleech , it responds to :CocList -I symbols command. I think it should be https://microsoft.github.io/language-server-protocol/specification#workspace_symbol

dantleech commented 4 years ago

that should be low-hanging fruit :)

dantleech commented 4 years ago

I actually thought this was document symbols (:CocList outline) which was pretty easy and implemented now in develop.

CocList -I symbols is workspace symbols - which is a bit more tricky, but still should be possible via. the indexer ...

dantleech commented 2 years ago

this has been basically implemented