Open Taluu opened 3 years ago
Can you elaborate? How is this relating to the coc-phpactor extension? or how would it be useful?
It is related because coc-phpactor is responsible to launch the phpactor langserver (through the command phpactor language-server
), so adding an argument or option (here -vvv
for example) should be done on coc-phpactor extension side.
It is useful when the langserver crashes, as having <date> INFO (pid:<pid>) [language-client-index] - Language server "phpactor" started with <pid>
in :CocInfo
isn't quite useful after a coc error phpactor server crashed 5 times in the last 3 minutes. The server will not be restarted
, don't you think ? It could allow us to have more details when looking up what went wrong.
Agree increased verbosity can be useful for seeing the stack trace etc, so happy to include a verbosity setting.
But Phpactor would show the error at least when it crasehs. Does :CocCommand workspace.showOutput
give the same output as :CocInfo
?
I wasn't the one on who that crashed (just converted someone to phpactor :tada:). will keep that in mind next time. :}
(His problem was that indexing the vendor directory took too much memory, as he has a memory_limit on his php cli config ; triggering it manually in console with -d memory_limit=-1
did the trick)
develop
improves that a bit - it now shows how much memory is being consumed in the indexing progress notification.
Also if the kernel is killing the process, there's nothing interesting to see
Wouldn't we have at least a "tried to allocate ..." on the indexing ?
oh maybe - I've just been seeing lots of Process killed
kernel messages recently due to memory :smile:
We can't specify if we want a
quit
,v
,vv
orvvv
mode for the phpactor client. We should probably see how it can be done.