search

phpactor / language-server-phpactor-extensions

MIT License
0 stars 4 forks source link

Replace completion command for imports by additionalTextEdits #50

Closed weeman1337 closed 3 years ago

weeman1337 commented 3 years ago

@dantleech maybe you could put this into your local setup and test it additionally to me since this is a critical place. Completions and imports are nearly used every day (even every minute :D - at least by me).

I did my very best for testing

With these changes phpactor/phpactor#1300 doesn't appear any more.

dantleech commented 3 years ago

Confirm that this fixes the issue I reported earlier :+1:

dantleech commented 3 years ago

Needs php-cs-fixer fix

weeman1337 commented 3 years ago

Needs php-cs-fixer fix

Puh - I did that; but with PHP 7.4.

Why does running the cs-fixer reports braces to be set different depending on using PHP 7.3 / PHP 7.4? :/

dantleech commented 3 years ago

:shrug:

weeman1337 commented 3 years ago

@dantleech I don't want to stress you :D Last time you mentioned you have forgotten a PR. So see this as a friendly reminder.

I am desperately waiting for this one. After that I can switch to Phpactor.

dantleech commented 3 years ago

Thanks, forgotten indeed....

dantleech commented 3 years ago

I've updated phpactor master now too