search

phpactor / language-server-phpactor-extensions

MIT License
0 stars 4 forks source link

IndexerHandler: use ProgressNotifier #51

Open camilledejoye opened 3 years ago

camilledejoye commented 3 years ago

Depends on https://github.com/phpactor/language-server-extension/pull/23

Make use of the new ProgressNotifier in the IndexHandler.

@dantleech I introduced a BC break by adding the new dependency. Do you prefer that I handle it gracefully and trigger a depreciation if the service is not provided ?

It works on my side, the only annoying thing is that the last message disappear right away but ti's a client configuration issue IMO and it should not prevent us from using this feature on our side.

dantleech commented 3 years ago

It's fine to break BC here this isn't a reusable package