search

phpactor / language-server

Generic Language Server
MIT License
42 stars 11 forks source link

Remove null values from responses #15

Closed camilledejoye closed 4 years ago

camilledejoye commented 4 years ago

We had issues when the response contains null values. They aren't always handled properly by the clients but it seems that all clients checks if a nullable key exists or not. Therefore we might have less issues by simply removing them entirely.

camilledejoye commented 4 years ago

I wonder if it was a good idea to apply it on the ResponseFormatter. Because it will also impact the requests, could it have a negative effect ?

dantleech commented 4 years ago

If clients are sending requests with missing fields, then it's only fair they receive them too.