search

phpactor / ncm2-phpactor

NCM2 Integration for Phpactor
55 stars 6 forks source link

The `$` is doubled when autocompleting variables #1

Closed Taluu closed 6 years ago

Taluu commented 6 years ago

If I search a variable after typing as $ (so $ + C-n), for a $foo variable, I end up with a $$foo instead of expected $foo.

Not sure if it's phpactor or ncm, but I think it's form the plugin, as I didn't have the issue with deoplete.

Taluu commented 6 years ago

Hum, this doesn't appear to be fixed. I updated this morning the plugin, and I still have double $s.

Reproducing : Type $, and <C-n>. Variables are proposed. If we complete with one of those, we end up with $$varName if we selected `$varName.

dantleech commented 6 years ago

I can reproduce this issue on the previous commit, but after the fix it works as expected.

Taluu commented 6 years ago

Can't reproduce either... I was up to date, but maybe it's because I hadn't restarted nvim or something like that ?

dantleech commented 6 years ago

Yeah, that would probably do it :)