search

phparkitect / arkitect

Put your architectural rules under test!
MIT License
703 stars 36 forks source link

Add return type to `PhpArkitectApplication::getLongVersion()` for Symfony 7.x compatibility #418

Closed ben-challis closed 8 months ago

ben-challis commented 8 months ago

Resolves #417, this method does not have a return type in 6.x and below; and as this is type narrowing rather than changing/widening it is backwards compatible.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (10f515b) 94.33% compared to head (d1a015e) 94.33%. Report is 1 commits behind head on main.

Files Patch % Lines
src/CLI/PhpArkitectApplication.php 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ========================================= Coverage 94.33% 94.33% Complexity 572 572 ========================================= Files 67 67 Lines 1500 1500 ========================================= Hits 1415 1415 Misses 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vibby commented 8 months ago

Please, merge this no-risk PR :D